Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OONI Run v2 refactor #805

Closed
wants to merge 67 commits into from
Closed

OONI Run v2 refactor #805

wants to merge 67 commits into from

Conversation

hellais
Copy link
Member

@hellais hellais commented Feb 16, 2024 •
edited
Loading

Align OONI Run v2 to the original specification.

Includes:

  • Switch to using postgresql for supporting OONI Run v2 descriptors
  • Always returning the full models when fetching and listing
  • Use SQLAlchemy with alembic to handle database migrations
  • Upgrade to SQLAlchemy 2.x so that we can benefit from proper typing support
  • Fix some bugs in the existing implementation

@hellais hellais mentioned this pull request Feb 23, 2024
Open
7 tasks
hellais added a commit to ooni/spec that referenced this pull request Feb 23, 2024
@hellais
Update OONI Run v2 spec following refactoring: ooni/backend#805
3af7870 
This PR superseeds: #278
@hellais hellais mentioned this pull request Feb 23, 2024
Closed
@hellais hellais requested a review from DecFox February 26, 2024 10:03
@hellais
Fix port mapping
8080727
@hellais
Run alembic migration before starting pg host
02a3839
@hellais
Ensure poetry is setup
bbaaa8d
@hellais
Fix returning of empty list when descriptors are not found
d7842b0
@hellais
Add checks for descriptors
e02f6b8
@hellais
Rename list ooni run links endpoint
a9b8bc2
@hellais
Fix tests based on API change
21cb6b7
@hellais
Fix reference to postgresql
8f5321f
@hellais
Fix smoke test
09ff4fb
@hellais
Add wait function to start the smoketest
8276587
@hellais
Provide more information about crash
f387c44
@hellais
Temporarily disable the smoke test
e853fd4
@hellais
bump dataapi version
f0c4bfc
@hellais
Temporarily enable all origins
622bf25
@hellais
Bump version
a2c5556
@hellais
Add codebuild buildspec
504454c
@hellais
Add .coverage to gitignore
f04b10e
@hellais
Fix path export
82a0999
@hellais
Fix command
d6751d8
@hellais
Fixes to buildspec
572c0b6
@hellais
Add integration with ECR
6d5b9dc
@hellais
Fix ECR login
e598308
@hellais
Fix region name
d3014a2
@hellais
Push to dockerhub
93aed8e
@hellais
Write artifact to project root
2171765
@hellais
Copy link
Member Author

hellais commented Mar 5, 2024

@DecFox confirmed that he has reviewed this branch until f0c4bfc. I am going to proceed with landing this.

@DecFox if you have some comments about the rest of the review feel free to drop another comment here so I can address it as future work.

@hellais
Copy link
Member Author

hellais commented Mar 5, 2024

I will manually squash the git history to make it easier to look at the changeset later.

@hellais
Copy link
Member Author

hellais commented Mar 5, 2024

@DecFox I rewrote the git history so it's easier to tell what's going on. The last commit you have viewed as all been squashed into d2aa0af, so all the new stuff is just this commit: c3f5225.

I am closing this PR as merged.

@hellais hellais closed this Mar 5, 2024
@hellais hellais mentioned this pull request Mar 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DecFox DecFox Awaiting requested review from DecFox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hellais